fix: undoing and redoing deleting procedures #6722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b031dd to
f49d90f
Compare
f49d90f to
1062097
Compare
95369bb to
1062097
Compare
rachel-fenichel
approved these changes
Jan 6, 2023
2eb3b29 to
bf99b25
Compare
bf99b25 to
acdaae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #6526
Proposed Changes
Discovered that when a procedure was deleted, and then the action was undone, procedure callers that were deleted with the definition were not properly reassociated with the procedure definition when they were deserialized. So e.g. when the definition was renamed, callers would not be renamed with it.
Reason for Changes
Fixing bugs is rad!
Test Coverage
Added tests for undoing and redoing deleting procedures.
Documentation
N/A
Additional Information
Dependent on #6721