-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: mini workspace bubble #7096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mini workspace bubble #7096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want bubbles to be pure views with a object oriented structure. This works toward that =)
I'm not quite sure what you mean by "pure views".
Am I correct in understanding that the current Mutator
(really: block button with gear icon) will in future use a MiniWorkspaceBubble
instead of whatever it currently uses?
This is the one I'm most nervous about since it has so much functionality that I can't test it all. But the simple case looks good! And I added validation to hopefully restrict peeps to those use cases.
I was surprised that the mini workspace doesn't support scrolling, trash, etc. Are there technical limitations why that is, or is this just policy? If the latter, why?
If we want we can also mark the constructor
@internal
until we're more confident in it.
That seems like a good idea, though not exporting it (as is presently the case) is probably just as effective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want bubbles to be pure views with a object oriented structure. This works toward that =)
I'm not quite sure what you mean by "pure views".
Am I correct in understanding that the current Mutator
(really: block button with gear icon) will in future use a MiniWorkspaceBubble
instead of whatever it currently uses?
This is the one I'm most nervous about since it has so much functionality that I can't test it all. But the simple case looks good! And I added validation to hopefully restrict peeps to those use cases.
I was surprised that the mini workspace doesn't support scrolling, trash, etc. Are there technical limitations why that is, or is this just policy? If the latter, why?
If we want we can also mark the constructor
@internal
until we're more confident in it.
That seems like a good idea, though not exporting it (as is presently the case) is probably just as effective.
Yes!
There are technical limitations related to how the workspace gets sized (and automatically resized). We can't support scrolling because the workspace should never be scrollable (always resizing to show the whole workspace). We can't support the trashcan because (currently) we don't take the size of the trashcan into account when resizing. In the future we can always add support for these things! I just don't have time to implement that right now.
I think we do want to export this for documentation purposes though. I'm pretty sure if it's not exported then API extractor won't include information about what other methods it has and what not. I'll mark it as internal just in case. |
Does API extractor include information about things marked But if you've checked that it is output as you intend then great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to due consideration given to remaining unresolved comments (changes at your discretion).
The basics
npm run format
andnpm run lint
The details
Resolves
Fixes #7045
Proposed Changes
Adds a new kind of bubble which is a mini workspace bubble.
Reason for Changes
We want bubbles to be pure views with a object oriented structure. This works toward that =)
Test Coverage
Manually tested by hacking into the warning icon. Looks the same as bubbles did previously.
This is the one I'm most nervous about since it has so much functionality that I can't test it all. But the simple case looks good! And I added validation to hopefully restrict peeps to those use cases.
If we want we can also mark the constructor
@internal
until we're more confident in it.Documentation
N/A
Additional Information