-
Notifications
You must be signed in to change notification settings - Fork 3.8k
refactor(generators): Introduce JavascriptGenerator
class, Order
enum
#7153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Jun 13, 2023
Oh, bother: I merged before pushing commit with comment update. Drat. |
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Jun 13, 2023
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Jun 13, 2023
4 tasks
cpcallen
added a commit
that referenced
this pull request
Jun 13, 2023
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Jun 14, 2023
Addresses various nits that escaped previous PRs: * Add TSDoc for `BlockGenerator` in `core/generator.ts` for PR google#7150. * Fix bad formating in `generators/javascript.js` from PR google#7153. * Add missing `@enum` tag that should have been included in PR google#7160. * Delete obsolete comment from `generators/python.js` for PR google#7163.
cpcallen
added a commit
that referenced
this pull request
Jun 14, 2023
Addresses various nits that escaped previous PRs: * Add TSDoc for `BlockGenerator` in `core/generator.ts` for PR #7150. * Fix bad formating in `generators/javascript.js` from PR #7153. * Add missing `@enum` tag that should have been included in PR #7160. * Delete obsolete comment from `generators/python.js` for PR #7163.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
First part of #7085.
Proposed Changes
JavascriptGenerator
class to be the class of whichjavascriptGenerator
is an instance (without any additional properties making it a singleton).Order
enum (for now Closure-style) for the operator precedence table.javascriptGenerator
toJavaScript
ingenerators/javascript/*.js
.Behaviour Before/After Change
There should be no changes in behaviour.
Reason for Changes
See #7085.
Test Coverage
Passes
npm test
; no changes to manual testing anticipated.Documentation
Documentation for the
JavascriptGenerator
class andOrder
enum should be automatically generated by our JSDoc configs (though if this is not currently the case then we should fix that).Additional Information
It is now possible to create multiple
JavascriptGenerator
objects, which can share (or not share) block generator implementations. Note that new instances do not by default come with any generator functions pre-installed.We now provide an enum of the operator precedence values (order of operations) constants as a separate export:
DEPRECATION: The
.ORDER_*
constants onjavascriptGenerator
are deprecated; they still exist but are no longer part of the documented API and will be removed in a future version of Blockly. We recommend that you update your custom generator code to use theOrder
enum at your earliest convenience.