fix: Fix bug that prevented editing workspace comments on Firefox. #8779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // and steal focus away from the editor/comment. | ||
| e.stopPropagation(); | ||
| } else { | ||
| gesture.handleCommentStart(e, this); |
There was a problem hiding this comment.
Next question: why is this not already fixed by the other uses of isTargetInput in inject.ts and gesture.ts?
There was a problem hiding this comment.
handleCommentStart() doesn't ever call doStart(), where isTargetInput() is checked; handleWsStart does, but by the time that's called the event has already bubbled up to the workspace and stolen focus away from the textarea, so it's too late. Likewise, inject.ts only checks it for keydown and contextmenu events, not clicks.
rachel-fenichel
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8768
Proposed Changes
This PR fixes a bug that prevented editing the text of workspace comments on Firefox.