feat(WorkspaceSvg): Add support for tracking keyboard moves #8959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
May 2, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8874.
Proposed Changes
.keyboardMoveInProgresswith associated@internalset method toWorkspaceSvgto allowMoverto inform the workspace when a keyboard-initiated move is in progress.Workspace.prototype.isDraggingto return true if.keyboardMoveInProgressis true as well as when a drag gesture is in progress.Reason for Changes
Make dragging behaviour more consistent regardless of whether initiated by pointer or keyboard.
Test Coverage
Tested manually by console calls to
.setKeyboardMoveInProgress.Documentation
JSDocs for
.isDraggingupdated to describe current behaviour.Additional Information
Filed #8960 to implement a less kludgy approach once
Moveris part of core (or can at least be more easily accessed from core than at present).