Skip to content
This repository was archived by the owner on Jul 15, 2024. It is now read-only.

tests: add test cases for int64 field, capital letter field, map pagination #510

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Conversation

georgiyekkert
Copy link
Contributor

@georgiyekkert georgiyekkert commented Aug 12, 2021

Add tests for:

  1. Pagination with map response
  2. A field with format: int64
  3. A field that starts with a capital letter, like IPAddress

@georgiyekkert georgiyekkert requested a review from a team as a code owner August 12, 2021 17:25
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/java-compute API. label Aug 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add in the description which specific new tests you are adding here

if (entry.getKey().equals("zones/" + DEFAULT_ZONE)) {
for (AcceleratorType type : entry.getValue().getAcceleratorTypesList()) {
if (type.getName().equals("nvidia-tesla-t4")) {
presented = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean "present"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used "presented" as a short form of "is presented in the list"

@georgiyekkert georgiyekkert changed the title tests: add more integration tests for compute tests: add test cases for int64 field, capital letter field, map pagination Aug 12, 2021
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ДПЕЬ

@vam-google vam-google merged commit 17f3b46 into googleapis:master Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/java-compute API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants