feat: Copy Backup Support #1778

asthamohta · 2022-03-24T08:52:28Z

No description provided.

generated-files-bot · 2022-03-24T08:52:32Z

Warning: This pull request is touching the following templated files:

samples/pom.xml

snippet-bot · 2022-03-24T08:52:34Z

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

thiagotnunes

Be careful when accepting my code suggestions, as you need to change the commit title, otherwise the conventionalcommits check will fail. Feel free to, instead of accepting the suggestions, implementing the same in your local machine.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java

thiagotnunes · 2022-03-25T05:25:46Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java

+     *
+     * <p>Returns the names of the destination backups being created by copying this source backup.
+     */
+    protected abstract Builder setReferencingBackup(ProtocolStringList referencingBackup);


We should not use the protobuf specific types here. Instead of ProtocolStringList, could you use List<String>?

google-cloud-spanner/src/test/java/com/google/cloud/spanner/BackupTest.java

samples/pom.xml

google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java

thiagotnunes

We need to resolve the breaking changes, populate the new fields when reading the proto and remove the samples

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java

google-cloud-spanner/src/test/java/com/google/cloud/spanner/BackupTest.java

thiagotnunes · 2022-03-25T10:19:30Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/Backup.java

        .setDatabase(DatabaseId.of(proto.getDatabase()))
        .setEncryptionInfo(EncryptionInfo.fromProtoOrNull(proto.getEncryptionInfo()))
        .setProto(proto)
+        .setMaxExpireTime(Timestamp.fromProto(proto.getMaxExpireTime()))


Did we test with null max expire time and null referencingBackupsList?

We won't get a null value over here. The addAll function checks for non null values-> https://github.com/protocolbuffers/protobuf/blob/master/java/core/src/main/java/com/google/protobuf/AbstractMessageLite.java#L408

google-cloud-spanner/clirr-ignored-differences.xml

thiagotnunes

I will remove my request changes so you are not blocked by my review, but please address the method name change

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

ansh0l and others added 15 commits March 24, 2022 13:28

feat: copy backup - porting code changes

10ab028

feat: copy backup - porting partial sample

1902e83

feat: copy backup - cleaning up tests

d4b83f9

feat: copy backup - cleaning up samples

fe24c7e

feat: copy backup - cleaning up samples

dc27ff7

feat: copy backup signature fixes

3b4582b

feat: copy backup sample fixes

108710e

feat: copy backup - review fixes

ca2828a

feat: copy backup - review fixes

26a7a6e

feat: copy backup checkstyle fixes

1ef7563

feat: make CopyBackup sample runnable

537f07b

fix: checkstyle violation

ca240c6

feat: adding max expire time and get referencing database support

a94174b

samples: adding copy backup operation support

780d674

adding documentation

8670fb6

asthamohta requested review from a team as code owners March 24, 2022 08:52

product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Mar 24, 2022

blunderbuss-gcf bot assigned lesv Mar 24, 2022

linting changes

2d627aa

asthamohta force-pushed the copy-backup-final branch from 48d840d to 2d627aa Compare March 24, 2022 08:55

asthamohta requested review from ansh0l and olavloite March 24, 2022 08:56

thiagotnunes reviewed Mar 25, 2022

View reviewed changes

thiagotnunes requested changes Mar 25, 2022

View reviewed changes

changes as per review

430f772

asthamohta force-pushed the copy-backup-final branch from a28dc35 to 10d2134 Compare March 25, 2022 07:52

asthamohta changed the title ~~feat: Copy Backup support and samples~~ feat: Copy Backup support Mar 25, 2022

asthamohta requested a review from thiagotnunes March 25, 2022 07:54

removing samples

b06a3df

asthamohta force-pushed the copy-backup-final branch from 10d2134 to b06a3df Compare March 25, 2022 07:56

asthamohta added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: spanner Issues related to the googleapis/java-spanner API. labels Mar 25, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022

asthamohta added owlbot:run Add this label to trigger the Owlbot post processor. api: spanner Issues related to the googleapis/java-spanner API. and removed samples Issues that are directly related to samples. labels Mar 25, 2022

olavloite approved these changes Mar 25, 2022

View reviewed changes

rajatbhatta reviewed Mar 25, 2022

View reviewed changes

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java Outdated Show resolved Hide resolved

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java Outdated Show resolved Hide resolved

review changes

809465c

asthamohta force-pushed the copy-backup-final branch from a4d44b2 to 809465c Compare March 25, 2022 10:06

asthamohta changed the title ~~feat: Copy Backup support~~ feat: Copy Backup Support Mar 25, 2022

rajatbhatta approved these changes Mar 25, 2022

View reviewed changes

thiagotnunes reviewed Mar 25, 2022

View reviewed changes

google-cloud-spanner/clirr-ignored-differences.xml Outdated Show resolved Hide resolved

thiagotnunes reviewed Mar 25, 2022

View reviewed changes

thiagotnunes approved these changes Mar 25, 2022

View reviewed changes

changes as per review

a968222

asthamohta force-pushed the copy-backup-final branch from cfc43a8 to a968222 Compare March 28, 2022 05:06

asthamohta added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 28, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022

🦉 Updates from OwlBot post-processor

8d304dd

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

asthamohta merged commit dc79366 into googleapis:main Mar 28, 2022

release-please bot mentioned this pull request Mar 28, 2022

chore(main): release 6.23.0 #1786

Merged

feat: Copy Backup Support #1778

feat: Copy Backup Support #1778

Uh oh!

Conversation

asthamohta commented Mar 24, 2022

Uh oh!

generated-files-bot bot commented Mar 24, 2022

Uh oh!

snippet-bot bot commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

No region tags are edited in this PR.

Uh oh!

thiagotnunes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thiagotnunes Mar 25, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thiagotnunes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thiagotnunes Mar 25, 2022

Choose a reason for hiding this comment

Uh oh!

asthamohta Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thiagotnunes left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

snippet-bot bot commented Mar 24, 2022 •

edited

Loading