feat: Adding support for databoost enabled in PartitionedRead and PartitionedQuery #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatbhatta
approved these changes
Mar 17, 2023
Contributor
There was a problem hiding this comment.
Couple of points:
- Added minor nit comments. Please take a look.
- Let's add unit tests (in OptionsTest.java/AbstractReadContext.java) for handwritten code changes made.
Apart from that, LGTM (subject to proto changes merged and the github checks pass here).
Thanks for working on this, @gauravpurohit06 !
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java
Show resolved
Hide resolved
arpan14
pushed a commit
to arpan14/java-spanner
that referenced
this pull request
Apr 28, 2023
…titionedQuery (googleapis#2316) * feat: Adding support for spanner serverless analytics * feat: Adding BetaAPI annotation to flag out changes are under development * test: Adding Integration test * style: formatting * feat: Using databoost field instead of serverless analytics * feat: Integration test and sample. * refactor: method name change * refactor: minor refactoring * refactor: Adding more junit and java docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for databoost enabled in PartitionedRead and PartitionedQuery