test(retry): refactor things to ensure teardown is run per test #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor teardown function to be tolerant of multiple objects being created during a test (copy, rewrite etc.), and bucket and hmac key existence. * Fix RpcMethodMapping.Builder not correctly carrying though a specified tearDown operation * Update mapping 26 (storage.hmacKey.delete) not fully clearing the state it was modifying Related to #1095 (I don't think cleanup is the sole reason for test failures, but this does seem to alleviate the failures for several of the seeds.)
frankyn
reviewed
Oct 12, 2021
google-cloud-storage/src/test/java/com/google/cloud/storage/conformance/retry/CtxFunctions.java
Show resolved
Hide resolved
...loud-storage/src/test/java/com/google/cloud/storage/conformance/retry/RpcMethodMappings.java
Outdated
Show resolved
Hide resolved
frankyn
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1095 (I don't think cleanup is the sole reason for test failures, but this does seem to alleviate the failures for several of the seeds.)