Skip to content

fix: use property for kms client version #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Aug 28, 2020

Fixes #486 ☕️

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2020
@frankyn frankyn changed the title use property for kms client version fix: use property for kms client version Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #487   +/-   ##
=========================================
  Coverage     64.60%   64.60%           
+ Complexity      626      617    -9     
=========================================
  Files            32       32           
  Lines          5235     5235           
  Branches        506      507    +1     
=========================================
  Hits           3382     3382           
  Misses         1694     1694           
  Partials        159      159           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da90518...8fc2a1b. Read the comment docs.

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Aug 29, 2020
@frankyn frankyn merged commit 7dacd34 into master Aug 31, 2020
@frankyn frankyn deleted the update-kms-version branch August 31, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate kms library versions
2 participants