Skip to content

fix deprecations and other warnings #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix deprecations and other warnings #66

merged 2 commits into from
Jan 15, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 15, 2020

@elharo elharo requested a review from BenWhitehead January 15, 2020 17:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2020
@codecov
Copy link

codecov bot commented Jan 15, 2020 •
edited
Loading

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #66   +/-   ##
========================================
  Coverage      63.3%   63.3%           
  Complexity      528     528           
========================================
  Files            30      30           
  Lines          4720    4720           
  Branches        450     450           
========================================
  Hits           2988    2988           
  Misses         1571    1571           
  Partials        161     161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d467d96...fd218be. Read the comment docs.

@BenWhitehead
Copy link
Collaborator

Contents of change seem fine to me, but it looks like you'll need to run the code formatter to get the lints to pass.

@elharo
Copy link
Contributor Author

elharo commented Jan 15, 2020

ran the formatter

@elharo elharo merged commit 2e46ab3 into master Jan 15, 2020
@elharo elharo deleted the percent branch January 15, 2020 21:54
@yoshi-automation yoshi-automation mentioned this pull request Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @BenWhitehead @googlebot