Skip to content

Include compiled cmap resources to simplify installation for CJK languages #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2016

Conversation

orangain
Copy link
Contributor

Although this PR will increase package size from 4.0MB to 7.4MB, I think 3.4MB does not matter today; simplifying installation step is more important for newcomers.

Changes

  • Run make cmap and git add pdfminer/cmap.
  • Modify MANIFEST.in not to include cmaprsrc dir in the sdist package.
  • Add pdfminer/cmap/README.txt to include license in the sdist package.
  • Remove installation guide specific to CJK languages from README.md.

Package Size

Before: 4.0MB

$ python setup.py -q sdist --formats=gztar,zip
warning: no files found matching '*.txt'
warning: sdist: standard file not found: should have one of README, README.rst, README.txt

$ ll dist/
total 16344
-rw-r--r--  1 orange  wheel  4166269 12 27 12:18 pdfminer.six-20150601.tar.gz
-rw-r--r--  1 orange  wheel  4198099 12 27 12:18 pdfminer.six-20150601.zip

After: 7.4MB

$ python setup.py -q sdist --formats=gztar,zip
warning: sdist: standard file not found: should have one of README, README.rst, README.txt

$ ll dist/
total 30152
-rw-r--r--  1 orange  staff  7631040 12 27 13:05 pdfminer.six-20150601.tar.gz
-rw-r--r--  1 orange  staff  7801523 12 27 13:05 pdfminer.six-20150601.zip

…uages

* Run `make cmap` and `git add pdfminer/cmap`.
* Modify MANIFEST.in not to include cmaprsrc dir in the sdist package.
* Add pdfminer/cmap/README.txt to include license in the sdist package.
* Remove installation guide specific to CJK languages from README.md.
@landscape-bot
Copy link

Code Health
Repository health decreased by 0.72% when pulling f1d5d68 on orangain:include-cmap into 72b2bc3 on goulu:master.

goulu added a commit that referenced this pull request Jan 18, 2016
Include compiled cmap resources to simplify installation for CJK languages
@goulu goulu merged commit 2103e58 into pdfminer:master Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants