switch max attribute bytes to per tenant and also check event links a… #4633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd instrumentation scopes
joe-elliott
reviewed
Jan 28, 2025
joe-elliott
reviewed
Jan 28, 2025
| MaxLocalTracesPerUser: l.MaxLocalTracesPerUser, | ||
| MaxGlobalTracesPerUser: l.MaxGlobalTracesPerUser, | ||
| TenantShardSize: l.IngestionTenantShardSize, | ||
| MaxAttributeBytes: l.IngestionMaxAttributeBytes, |
Collaborator
There was a problem hiding this comment.
do we have tests that lock this copying behavior down?
Contributor
Author
There was a problem hiding this comment.
i am adding a test to make sure the conversion between the legacy and new format is working. is that what you're looking for?
Collaborator
There was a problem hiding this comment.
yeah, also just kind of asking if we have these tests generally?
joe-elliott
approved these changes
Jan 29, 2025
electron0zero
approved these changes
Jan 29, 2025
Contributor
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for updating the docs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Enforce max attribute byte size at the event, link, and instrumentation level. Make config per tenant a well.
BREAKING CHANGE ***
renamed
max_span_attr_byte=>max_attribute_bytesWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]