Allow configuration of min/max input blocks for compaction provider #5373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
approved these changes
Jul 9, 2025
Contributor
mapno
left a comment
There was a problem hiding this comment.
Can you add a chlog entry?
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Jul 18, 2025
…rafana#5373) * Allow configuration of min/max input blocks for compaction provider * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
With the new scheduled compactions, we're observing that jobs handed out in sequence of difficulty often mean that the jobs are too easy for workers to complete, which results in lower throughput because the scheduler has to spend more time scheduling and handling the jobs. Eventually the jobs handed out are more difficult, but it can take some time before this happens, which results in a valley of low throughput. This may happen at the beginning of working on a new tenant, for example, and in a large environment with many tenants, the performance is sub-optimal. I believe this warrants an allowable configuration on the compaction provider, proposed here.
Historically, the min/max input blocks have been hard-coded to match the parquet version performance. It would be easy to try and compact too many blocks and drive memory use while combining. Looking at the memory and some recent improvements in the compaction process, I think we can begin to think about allowing this to be configurable.
Users should go slow and think hard about changing these defaults.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]