Command tempo-cli analyse block(s) skips over array values #5380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the IsArray column would have been difficult with the 'parquetinspect' package. Therefore the aggregation was re- implemented using iterators from 'parquetquery'
The package is no longer used
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Jul 18, 2025
) * The analyse block sub command skips attributes with arrays Reading the IsArray column would have been difficult with the 'parquetinspect' package. Therefore the aggregation was re- implemented using iterators from 'parquetquery' * Print skipped attributes in full sumary * Remove parquetinspect package The package is no longer used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The analyse block sub command is used to find candidates for dedicate attribute columns. So far the sub commands
analyse blockandanalyse blocksincluded attributes containing string arrays in this analysis. As a result those attributes were configured as dedicated attribute columns.Dedicated attribute columns only support string attributes. When attributes with string array values are configured as dedicated attribute column, it is no longer possible to query for those attributes.
With this change the respective sub commands skip over attributes with array values in order to avoid making misleading suggestions for dedicated attribute columns.
Note: Reading the
IsArraycolumn would have been difficult with theparquetinspectpackage. Therefore the aggregation was re-implemented using iterators fromparquetquery. Theparquetinspectwas no longer used and therefore removed.Which issue(s) this PR fixes:
Contributes to https://github.com/grafana/tempo-squad/issues/724
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]