Skip to content

xds: make least request available by default #8253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

atollena
Copy link
Collaborator

@atollena atollena commented Apr 15, 2025

RELEASE NOTES:

  • xds: enable least request LB policy by default. It can be disabled by setting GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST=false in your environment.

@atollena atollena added Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Feature New features or improvements in behavior labels Apr 15, 2025
@atollena atollena added this to the 1.73 Release milestone Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (68205d5) to head (4d25427).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8253      +/-   ##
==========================================
- Coverage   82.13%   82.11%   -0.03%     
==========================================
  Files         412      412              
  Lines       40487    40486       -1     
==========================================
- Hits        33256    33247       -9     
- Misses       5867     5873       +6     
- Partials     1364     1366       +2     
Files with missing lines Coverage Δ
internal/envconfig/envconfig.go 100.00% <ø> (ø)
.../internal/xdsclient/xdslbregistry/xdslbregistry.go 90.47% <ø> (-0.83%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines -72 to -73
// This includes Least Request as well, since grpc-go does not support
// the Least Request Load Balancing Policy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find this? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually ran into it while reading the code a while ago... Then I figured I'd grep for "least request" in this PR.

@dfawley dfawley merged commit cb1613c into grpc:master Apr 16, 2025
22 of 24 checks passed
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants