-
Notifications
You must be signed in to change notification settings - Fork 4.5k
xds: make least request available by default #8253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8253 +/- ##
==========================================
- Coverage 82.13% 82.11% -0.03%
==========================================
Files 412 412
Lines 40487 40486 -1
==========================================
- Hits 33256 33247 -9
- Misses 5867 5873 +6
- Partials 1364 1366 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
// This includes Least Request as well, since grpc-go does not support | ||
// the Least Request Load Balancing Policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you find this? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually ran into it while reading the code a while ago... Then I figured I'd grep for "least request" in this PR.
RELEASE NOTES:
GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST=false
in your environment.