Improve CA certificate verification #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When https endpoint is used, the following message was shown: "warning: peer certificate won't be verified in this SSL session". This is because Net::HTTP#verify_mode is nil. Now, we verify server certificate by default. If you want to disable it, set Flickraw.check_certificate to false.
Contributor
|
I altered @nitoyon's code a bit to match the Net::HTTP options a bit better, and support specifying a directory of certifications instead of a single file: kueda@35cc21b. If that's of interest I can issue a separate pull request, or you guys can just pull in that commit. Wasn't really sure how to test it in the test suite, but it seems to be working for me. |
Secure endpoint connection fails if CA certificate file is old or is not installed. So, add FlickRaw.ca_file option to set the CA certificate file path even if we doesn't have root access right.
Contributor
Author
|
@kueda I pulled your commit & fix my typo. Thanks:exclamation: |
Owner
|
Thanks ! |
Contributor
Author
|
You're welcome and thanks too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use secure endpoints, server certificate was not verified and the following warning was shown:
warning: peer certificate won't be verified in this SSL session.By this PR,
FlickRaw.check_certificateto disable server certificate verificationFlickRaw.ca_fileto change the CA certificate file path