Skip to content

New resource: azurerm_web_pubsub_socketio #28992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2025
Merged

Conversation

sreallymatt
Copy link
Collaborator

@sreallymatt sreallymatt commented Mar 7, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

New resource: azurerm_web_pubsub_socketio

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • New Resource: azurerm_web_pubsub_socketio [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sreallymatt, this looks good but I did have a couple design questions to go over before signing off on it

@sreallymatt sreallymatt force-pushed the mp/pubsub-socketio-resource branch from 539d5cf to d74aa4f Compare March 17, 2025 19:56
@sreallymatt
Copy link
Collaborator Author

Tests still pass:

image

@sreallymatt sreallymatt requested a review from mbfrahry March 17, 2025 21:25
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think we could be a bit more verbose on the method names to avoid potential clashing later down the road

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sreallymatt sreallymatt merged commit 0c47502 into main Mar 20, 2025
33 checks passed
@sreallymatt sreallymatt deleted the mp/pubsub-socketio-resource branch March 20, 2025 18:33
@github-actions github-actions bot added this to the v4.24.0 milestone Mar 20, 2025
sreallymatt added a commit that referenced this pull request Mar 20, 2025
jackofallops added a commit that referenced this pull request Mar 21, 2025
* CHANGELOG.md for v4.24.0

* Update CHANGELOG.md #28173

* Update CHANGELOG.md #28964

* Update CHANGELOG.md #28569

* Update CHANGELOG.md for #28670

* Update CHANGELOG.md #29081

* Update CHANGELOG.md for #29082

* Update CHANGELOG.md #28888

* Update CHANGELOG.md #29012

* Update CHANGELOG.md #28485

* Update CHANGELOG.md for #29094

* Update CHANGELOG.md #29107

* Update CHANGELOG.md #28368

* Update for #29113 #28884 #28739 #28920 #29018 #28822 #28977 #29096 #29040

* Update for #29088

* Update CHANGELOG.md #29079

* Update CHANGELOG.md #28992

* prep for release

---------

Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants