-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New resource: azurerm_web_pubsub_socketio
#28992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sreallymatt, this looks good but I did have a couple design questions to go over before signing off on it
539d5cf
to
d74aa4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I think we could be a bit more verbose on the method names to avoid potential clashing later down the road
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* CHANGELOG.md for v4.24.0 * Update CHANGELOG.md #28173 * Update CHANGELOG.md #28964 * Update CHANGELOG.md #28569 * Update CHANGELOG.md for #28670 * Update CHANGELOG.md #29081 * Update CHANGELOG.md for #29082 * Update CHANGELOG.md #28888 * Update CHANGELOG.md #29012 * Update CHANGELOG.md #28485 * Update CHANGELOG.md for #29094 * Update CHANGELOG.md #29107 * Update CHANGELOG.md #28368 * Update for #29113 #28884 #28739 #28920 #29018 #28822 #28977 #29096 #29040 * Update for #29088 * Update CHANGELOG.md #29079 * Update CHANGELOG.md #28992 * prep for release --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: jackofallops <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: jackofallops <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
New resource:
azurerm_web_pubsub_socketio
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_web_pubsub_socketio
[GH-00000]This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.