Skip to content

Case insensitive enum parsing #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phadej merged 1 commit into from
May 30, 2019
Merged

Case insensitive enum parsing #373

phadej merged 1 commit into from
May 30, 2019

Conversation

@robbiemcmichael
Copy link
Contributor

@robbiemcmichael robbiemcmichael commented May 30, 2019

  • Changes all enum parsing to be case insensitive (at least I hope I've found all of the instances)
  • Standardises the error messages when parsing an unknown value

Closes #371

phadej
phadej approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

WIll merge after CI is green.

@phadej phadej mentioned this pull request May 30, 2019
Closed
@phadej phadej merged commit 1119ad4 into haskell-github:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@phadej phadej phadej approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enum parsing should be case insensitive

2 participants

@robbiemcmichael @phadej