Rename internal modules and expose them #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fairly optimistic that this won't cause disproportionate trouble with merge conflicts for the existing PRs:
I've left the idea of exposing the type constructors from a PVP-versioned module (#211 (comment)) for future work, since there seems to be some bikeshedding potential that isn't directly related to this work. @treeowl, @emilypi Could you review? And maybe @jamespayor, too? |
This also removes some "Stability" annotations from internal modules. Context: #211.
c56cbb0 to
f30fb45
Compare
|
Rebased. Thanks for the review, @emilypi! :) |
This was referenced Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with the module names suggested in #211 (comment).
Addresses #211.