IP Address Mapping display disagrees with configuration

[lochner]

With version 1.3.3, the Pade > Networking > IP Address Mapping display no longer agrees with the configured setting.  It always shows Automatic, even with the org.jitsi.videobridge.media.AWS_HARVESTER system property set to "disabled".

Inspection points to the apparent cause:

In /src/java/org/jitsi/videobridge/openfire/PluginImpl.java,
    org.jitsi.videobridge.media.AWS_HARVESTER
is mapped to these properties:
    org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER
    org.ice4j.ice.harvest.FORCE_AWS_HARVESTER

However, in /src/web/jitsi-videobridge.jsp, the associated radio button states are mapped
via /src/java/org/jitsi/videobridge/openfire/RuntimeConfiguration.java from these properties:
    org.jitsi.videobridge.DISABLE_AWS_HARVESTER
    org.jitsi.videobridge.FORCE_AWS_HARVESTER

[deleolajide]

Thanks for spotting this 👍

[gjaekel]

Seems also to affect FORCE_AWS_HARVESTER:

root@evalfire0 .../git/openfire-pade-plugin-master # grep "_AWS_HARVESTER" -r *                                     
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                    System.setProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER", "true" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                    System.clearProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                    System.setProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER", "false" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                    System.setProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER", "true" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                    System.clearProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                    System.clearProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:            System.clearProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:            System.clearProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                        System.setProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER", "true" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                        System.clearProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                        System.setProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER", "false" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                        System.setProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER", "true" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                        System.clearProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                        System.clearProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                System.clearProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/PluginImpl.java:                System.clearProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER" );
src/java/org/jitsi/videobridge/openfire/RuntimeConfiguration.java:        final boolean disabled = StackProperties.getBoolean( "org.jitsi.videobridge.DISABLE_AWS_HARVESTER", false );        <----==
src/java/org/jitsi/videobridge/openfire/RuntimeConfiguration.java:            return StackProperties.getBoolean( "org.jitsi.videobridge.FORCE_AWS_HARVESTER", false );        <----==
src/java/org/jivesoftware/openfire/plugin/ofmeet/JitsiJvbWrapper.java:                        props.setProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER", "true" );
src/java/org/jivesoftware/openfire/plugin/ofmeet/JitsiJvbWrapper.java:                        props.remove( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER" );
src/java/org/jivesoftware/openfire/plugin/ofmeet/JitsiJvbWrapper.java:                        props.setProperty( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER", "false" );
src/java/org/jivesoftware/openfire/plugin/ofmeet/JitsiJvbWrapper.java:                        props.setProperty( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER", "true" );
src/java/org/jivesoftware/openfire/plugin/ofmeet/JitsiJvbWrapper.java:                        props.remove( "org.ice4j.ice.harvest.DISABLE_AWS_HARVESTER" );
src/java/org/jivesoftware/openfire/plugin/ofmeet/JitsiJvbWrapper.java:                        props.remove( "org.ice4j.ice.harvest.FORCE_AWS_HARVESTER" );                   

[gjaekel]

@lochner If it's urgent for you, we may provide a snapshot build.

[deleolajide]

@lochner If it's urgent for you, we may provide a snapshot build.

The latestest snapshots are automatically built by GitHub Actions and can be found at http://igniterealtime.org/projects/openfire/plugin-archive.jsp?plugin=pade

[deleolajide]

The snapshot build after this fix is http://igniterealtime.org/projects/openfire/plugins/1.3.4-SNAPSHOT/pade.jar?snapshot=20210413.075814-13