Skip to content

Ionic method parameters are missing descriptions #634

@brandyscarney

Description

@brandyscarney

URL
https://github.com/ionic-team/ionic/tree/master/core/src/components/content#scrollbypointx-number-y-number-duration-number--promisevoid

What is missing or inaccurate about the content on this page?
All of the parameters in Ionic methods are missing descriptions. This should be added like the following:

  /**
   * Scroll by a specified X/Y distance in the component.
   *
   * @param x The amount to scroll on the horizontal axis.
   * @param y The amount to scroll on the vertical axis.
   * @param duration The amount of time it takes to scroll in milliseconds. Defaults to `0`.
   */

It is currently not documented either: https://ionicframework.com/docs/api/content#methods

Activity

added
contentIssues related to the contents of the documentation website
on Apr 16, 2019
brandyscarney

brandyscarney commented on Apr 18, 2019

@brandyscarney
MemberAuthor

I'm working on a PR for this in Ionic.

Related to #229.

brandyscarney

brandyscarney commented on Apr 23, 2019

@brandyscarney
MemberAuthor

Added by ionic-team/ionic-framework#18075, just needs to show in the docs

perrygovier

perrygovier commented on Feb 13, 2020

@perrygovier
Contributor

This is fixed by the signature section now

brandyscarney

brandyscarney commented on Feb 13, 2020

@brandyscarney
MemberAuthor

The method being documented isn't the problem, it's not knowing what the params mean:

Screen Shot 2020-02-13 at 5 48 43 PM

In this specific case they make sense enough to figure it out, but check others like Action Sheet's methods: https://ionicframework.com/docs/api/action-sheet#methods

Screen Shot 2020-02-13 at 5 49 52 PM

What is a role? They're documented in the code like the following


  /**
   * Dismiss the action sheet overlay after it has been presented.
   *
   * @param data Any data to emit in the dismiss events.
   * @param role The role of the element that is dismissing the action sheet.
   * This can be useful in a button handler for determining which button was
   * clicked to dismiss the action sheet.
   * Some examples include: ``"cancel"`, `"destructive"`, "selected"`, and `"backdrop"`.
   */
added
structuralTechnical upgrades and changes to the docs platform itself
on Feb 14, 2020
added and removed
structuralTechnical upgrades and changes to the docs platform itself
contentIssues related to the contents of the documentation website
on Sep 20, 2022
added
contentIssues related to the contents of the documentation website
and removed on Sep 28, 2022

9 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    contentIssues related to the contents of the documentation website

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Ionic method parameters are missing descriptions · Issue #634 · ionic-team/ionic-docs