fix(angular): add old IonBackButtonDelegate import#28831
Merged
liamdebeasi merged 1 commit intomainfrom Jan 16, 2024
Merged
Conversation
3 tasks
sean-perkins
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28827
What is the current behavior?
This import was renamed to
IonBackButtonas part of 9f20780. However, we did not consider that some developers are importing this to use withViewChild. While we should keep alignment with other component imports, we need to support the old import until we can make a breaking change in Ionic 8.What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
7.6.5-dev.11705352188.1c6cdb08