Skip to content

fix(angular): add focusTrap prop to modal and popover #29729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix(angular): add focusTrap prop to modal and popover #29729

merged 2 commits into from
Jul 24, 2024

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jul 22, 2024 •
edited
Loading

Issue number: resolves #29728

What is the current behavior?

The focusTrap property was missed when adding focus trapping configuration to the modal and popover. This results in a type error when developers attempt to assign to the property.

What is the new behavior?

  • Adds focusTrap property to ion-modal and ion-popover for the angular component wrappers
  • Resolves type warnings when using the property in angular

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 8.2.6-dev.11721672792.195afb09

@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:19pm

@github-actions github-actions bot added the package: angular @ionic/angular package label Jul 22, 2024
@sean-perkins sean-perkins changed the title fix(angular): add focusTrap prop to popover fix(angular): add focusTrap prop to modal and popover Jul 22, 2024
@sean-perkins sean-perkins marked this pull request as ready for review July 22, 2024 15:42
@sean-perkins sean-perkins requested a review from a team as a code owner July 22, 2024 15:42
@sean-perkins sean-perkins requested review from rugoncalves, brandyscarney and thetaPC and removed request for rugoncalves July 22, 2024 15:42
@sean-perkins sean-perkins enabled auto-merge July 22, 2024 17:52
@liamdebeasi
Copy link
Contributor

liamdebeasi commented Jul 24, 2024 •
edited
Loading

any update @brandyscarney ? ✨

@sean-perkins
Copy link
Contributor Author

+1 @brandyscarney 👀

brandyscarney
brandyscarney approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a new Angular starter and confirmed the Can't bind to 'focusTrap' since it isn't a known property of 'ion-popover'. error disappears with the dev build.

@sean-perkins sean-perkins added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 05913c3 Jul 24, 2024
61 checks passed
@sean-perkins sean-perkins deleted the sp/angular-popover-focus-trap branch July 24, 2024 14:25
This was referenced Aug 25, 2024
Open
Open
This was referenced Sep 21, 2024
Open
Open
@bdr0id bdr0id mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

@thetaPC thetaPC Awaiting requested review from thetaPC

Assignees
No one assigned
Labels
package: angular @ionic/angular package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Modal and Popover is missing focusTrap option in Angular
3 participants
@sean-perkins @liamdebeasi @brandyscarney