Skip to content

feat(datetime): add showAdjacentDays to display days from the previous and next months #30262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
Mar 19, 2025

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Mar 17, 2025

Issue number: Internal

What is the new behavior?

Adds a new property to datetime, showAdjacentDays, that when true will show the last days of the previous month and the first days of the next month. This will just occupy empty "cells" at the beginning of the month "table" and add rows to the table until a maximum of 6 rows are displayed.

Changes

  • add styles for adjacent day button
  • add showAdjacentDays property to datetime component
  • change month generation to respect new property
  • add visual tests to new feature

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

JoaoFerreira-FrontEnd and others added 30 commits February 24, 2025 18:44
- add showDaysOutsideCurrentMonth property to datetime  component;
- change month generation to respect new property;
- create specific test page for showDaysOutsideCurrentMonth;
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just requested a couple things!

@brandyscarney brandyscarney requested review from thetaPC and removed request for christian-bromann March 17, 2025 19:23
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit b67259e into feature-8.6 Mar 19, 2025
48 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-11118_V2 branch March 19, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants