-
Notifications
You must be signed in to change notification settings - Fork 13.5k
feat(datetime): add showAdjacentDays to display days from the previous and next months #30262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add showDaysOutsideCurrentMonth property to datetime component; - change month generation to respect new property;
- create specific test page for showDaysOutsideCurrentMonth;
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
…index.html Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just requested a couple things!
brandyscarney
approved these changes
Mar 18, 2025
thetaPC
requested changes
Mar 18, 2025
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
thetaPC
requested changes
Mar 19, 2025
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
thetaPC
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: angular
@ionic/angular package
package: core
@ionic/core package
package: vue
@ionic/vue package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the new behavior?
Adds a new property to datetime, showAdjacentDays, that when true will show the last days of the previous month and the first days of the next month. This will just occupy empty "cells" at the beginning of the month "table" and add rows to the table until a maximum of 6 rows are displayed.
Changes
showAdjacentDays
property to datetime componentDoes this introduce a breaking change?
Other information
Preview