fix(angular): add focusTrap prop to modal and popover#29729
Merged
sean-perkins merged 2 commits intomainfrom Jul 24, 2024
Merged
fix(angular): add focusTrap prop to modal and popover#29729sean-perkins merged 2 commits intomainfrom
sean-perkins merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liamdebeasi
approved these changes
Jul 24, 2024
Contributor
|
any update @brandyscarney ? ✨ |
Contributor
Author
|
+1 @brandyscarney 👀 |
brandyscarney
approved these changes
Jul 24, 2024
Member
brandyscarney
left a comment
There was a problem hiding this comment.
Tested in a new Angular starter and confirmed the Can't bind to 'focusTrap' since it isn't a known property of 'ion-popover'. error disappears with the dev build.
This was referenced Aug 25, 2024
This was referenced Sep 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29728
What is the current behavior?
The
focusTrapproperty was missed when adding focus trapping configuration to the modal and popover. This results in a type error when developers attempt to assign to the property.What is the new behavior?
focusTrapproperty toion-modalandion-popoverfor the angular component wrappersDoes this introduce a breaking change?
Other information
Dev-build:
8.2.6-dev.11721672792.195afb09