fix(input, textarea): ensure screen readers announce helper and error text when focused#29958
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tanner-reits
approved these changes
Oct 23, 2024
Contributor
tanner-reits
left a comment
There was a problem hiding this comment.
LGTM! Confirmed new behavior using VoiceOver 👍
brandyscarney
approved these changes
Oct 25, 2024
Member
brandyscarney
left a comment
There was a problem hiding this comment.
Verified this works using Android TalkBack and iOS VoiceOver. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Screen readers do not announce helper and error text when user is focused on the input or textarea. This does not align with the accessibility guidelines.
What is the new behavior?
ariatags are added to the native input and textarea in order to associate them to the helper and error texts.aria-describedBywill only be added to the native element based on helper or error text. If helper text exists then the helper text ID will be used. If the error text exists and the component has theion-touched ion-invalidclasses, then the error text ID will be used.aria-invalidwill only be added if the error text exists and the component has theion-touched ion-invalidclasses.Does this introduce a breaking change?
Other information
How to test:
mainbranchROU-11274branchmainbranchROU-11274branchKnown Webkit issues:
This fix will not work on macOS 16 and 17 as VoiceOver will not read any text using
aria-describedby. Works fine on macOS 18.