Change how we use readFileSync to renable mockfs to work. #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruebing
approved these changes
Aug 17, 2023
Member
mstruebing
left a comment
There was a problem hiding this comment.
Thanks for fixing it, I really this is fine and not a performance-critical path, especially since this is still not an official release yet, but even then I don't think it makes much of a difference in our case.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodejs 20.5.0 introduced an optimization for utf-8 files:
nodejs/node#48658
This broke mock-fs which we use for testing:
tschaub/mock-fs#377
This slightly changes how we read files to work around this issue. We won't get the performance improvements from the node changes, but given that config loading isn't really hot path, I don't think it matters.
We should consider reverting if/when mock-fs fixes this, but for now, this fixes CI/CD so we can merge other PRs.
cc @mstruebing