Fix controller unittests #7867
Merged
Fix controller unittests #7867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,9 +124,6 @@ func (r *RCExpectations) ExpectDeletions(rc *api.ReplicationController, dels int | |||
| // Decrements the expectation counts of the given rc. | |||
| func (r *RCExpectations) lowerExpectations(rc *api.ReplicationController, add, del int) { | |||
| if podExp, exists, err := r.GetExpectations(rc); err == nil && exists { | |||
| if podExp.add > 0 && podExp.del > 0 { | |||
There was a problem hiding this comment.
this isn't worth the loadint.
what can go wrong here, is go just being panicky? im ok with these being inaccurate as i'm just using them for logging. The memory isn't goint to get deallocated because these are members in a struct I have a ref to right?
There was a problem hiding this comment.
Yeah the memory won't get deallocated. It's complaining because it's technically a race (imagine a system where 64 bit ints took two words).
|
Fixes #7860 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make TestRCExpectations (#7860) use LoadInt. I think the watch failure is just a victim here because it needs to start multiple goroutines and their timings didn't quite line up within 100ms. It already uses a fake listwatcher, so suggestions other than just increasing its timeout are welcome.