Skip to content

Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation information to CronJob page #48860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation information to CronJob page #48860

merged 1 commit into from
Nov 26, 2024

Conversation

janetkuo
Copy link
Member

Description

Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation information to CronJob page

Issue

kubernetes/enhancements#4026

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2024
@janetkuo
Copy link
Member Author

/assign katcosgrove

@janetkuo
Copy link
Member Author

I don't have access to edit #48498, so I created this PR to make sure it doesn't slip @chanieljdan

@janetkuo janetkuo changed the base branch from main to dev-1.32 November 26, 2024 21:24
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1cf9e71
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67463fe9874d580008c6c6b0
😎 Deploy Preview https://deploy-preview-48860--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@janetkuo
Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation info…
1cf9e71 
…rmation to CronJob page

### Description
Add `batch.kubernetes.io/cronjob-scheduled-timestamp` annotation information to CronJob page
 
### Issue
[kubernetes/enhancements#4026](kubernetes/enhancements#4026)
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 1cf9e71
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67463fe9d6c61200081d2c17

@chanieljdan
Copy link
Contributor

Tech LGTM was given in #48498 (comment)

This PR cleans up a couple of nits

@reylejano
Copy link
Member

If the annotation is not in the well known labels, annotations, taints page then it should be added -- non-blocking

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@salaxander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a54f3a324fe8fd42ad35c6af2649a240bfa06407

@k8s-ci-robot k8s-ci-robot merged commit 0866f6c into kubernetes:dev-1.32 Nov 26, 2024
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Nov 26, 2024
@janetkuo janetkuo mentioned this pull request Nov 26, 2024
Closed
@soltysh
Copy link
Contributor

soltysh commented Nov 27, 2024

Thanks Janet!

@soltysh soltysh mentioned this pull request Nov 27, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@salaxander salaxander

@katcosgrove katcosgrove

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
7 participants
@janetkuo @chanieljdan @reylejano @k8s-ci-robot @salaxander @soltysh @katcosgrove