Clang does not check for ODR violations when merging concepts from different modules

[ilya-biryukov]

For this code:

// module.map
module "foo" {
  export * 
  header "foo.h"
}
module "bar" {
  export * 
  header "bar.h"
}

// foo.h
template <class T> concept A = true;

// bar.h
template <class T> concept A = false;

// foo.cpp
// clang -std=c++20 -fmodules -fimplicit-modules -fmodule-map-file=module.map foo.cpp
#include "foo.h"
#include "bar.h"

template <class T> void foo() requires A<T> {}
void main() { foo<int>(); }

Expected: compiling the code produces an error as concept A is defined differently in two consumed modules, therefore it produces an ODR violation.
Actual: no error about ODR violation. Depending on the chosen concept a call to foo<int>() either succeeds or fails.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

[llvmbot]

@llvm/issue-subscribers-clang-modules

[ChuanqiXu9]

Sent https://reviews.llvm.org/D129104

[ChuanqiXu9]

This one should be fixed.