Skip to content

Change api_key config type to password to prevent from leaks in debug logs. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2023
Merged

Change api_key config type to password to prevent from leaks in debug logs. #8

merged 4 commits into from
May 30, 2023

Conversation

mashhurs
Copy link
Contributor

When running Logstash with --config.debug, api_key may be leaked in the debug logs. This PR changes api_key type to password to prevent from leaks.

@mashhurs mashhurs added the bug label May 23, 2023
@mashhurs mashhurs self-assigned this May 23, 2023
roaksoax
roaksoax suggested changes May 25, 2023
View reviewed changes
Copy link

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add (at least) one tests that makes sure that when setting this config option, the value is of password type.

roaksoax
roaksoax suggested changes May 25, 2023
View reviewed changes
Copy link

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add (at least) one tests that makes sure that when setting this config option, the value is of password type.

@mashhurs mashhurs requested a review from roaksoax May 30, 2023 00:22
roaksoax
roaksoax approved these changes May 30, 2023
View reviewed changes
Copy link

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mashhurs mashhurs merged commit 542e05d into logstash-plugins:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaksoax roaksoax roaksoax approved these changes

Assignees

@mashhurs mashhurs

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api_key config can be leaked in debug mode.
2 participants
@mashhurs @roaksoax