Skip to content

Mark deprecated SSL settings as obsolete #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

robbavey
Copy link
Contributor

This commit marks the following SSL settings as obsolete:

'cacert', 'client_cert', 'client_key', 'keystore', 'truststore',
'keystore_password', 'truststore_password', 'keystore_type' and
'truststore_type'.

This commit marks the following SSL settings as obsolete:

'cacert', 'client_cert', 'client_key', 'keystore', 'truststore',
'keystore_password', 'truststore_password', 'keystore_type' and
'truststore_type'.
Add documentation to state that SSL settings are obsolete
@robbavey robbavey requested a review from karenzone November 18, 2024 18:17
@donoghuc
Copy link

Could probably use a CHANGELOG.md update to go along with the new version update.

Copy link

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments inline for consideration, and otherwise, LGTM.
I tested this locally, and it builds cleanly and renders as expected.

@robbavey robbavey merged commit 2fae93e into logstash-plugins:main Nov 21, 2024
2 checks passed
donoghuc added a commit to donoghuc/logstash-input-elasticsearch that referenced this pull request Dec 2, 2024
This commit updates the documentation to follow the pattern established in
logstash-plugins/logstash-output-http#147 for
documenting obsolete options.
donoghuc added a commit to donoghuc/logstash-input-elasticsearch that referenced this pull request Dec 3, 2024
This commit updates the documentation to follow the pattern established in
logstash-plugins/logstash-output-http#147 for
documenting obsolete options.
donoghuc added a commit to donoghuc/logstash-input-elasticsearch that referenced this pull request Dec 10, 2024
This commit updates the documentation to follow the pattern established in
logstash-plugins/logstash-output-http#147 for
documenting obsolete options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants