-
Notifications
You must be signed in to change notification settings - Fork 82
Mark deprecated SSL settings as obsolete #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit marks the following SSL settings as obsolete: 'cacert', 'client_cert', 'client_key', 'keystore', 'truststore', 'keystore_password', 'truststore_password', 'keystore_type' and 'truststore_type'.
Add documentation to state that SSL settings are obsolete
Could probably use a |
c51cf2b
to
b51e1f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments inline for consideration, and otherwise, LGTM.
I tested this locally, and it builds cleanly and renders as expected.
Co-authored-by: Karen Metts <[email protected]>
This commit updates the documentation to follow the pattern established in logstash-plugins/logstash-output-http#147 for documenting obsolete options.
This commit updates the documentation to follow the pattern established in logstash-plugins/logstash-output-http#147 for documenting obsolete options.
This commit updates the documentation to follow the pattern established in logstash-plugins/logstash-output-http#147 for documenting obsolete options.
This commit marks the following SSL settings as obsolete:
'cacert', 'client_cert', 'client_key', 'keystore', 'truststore',
'keystore_password', 'truststore_password', 'keystore_type' and
'truststore_type'.