fix: disregard empty and/or fields in buildSelect #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhilash Murthy <[email protected]>
1130969 to
bbfa561
Compare
achrinza
approved these changes
Sep 21, 2021
dhmlau
approved these changes
Sep 24, 2021
Member
dhmlau
left a comment
There was a problem hiding this comment.
@abhilashmurthy, thanks for the contribution. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to v5.2.1, empty and/or fields were handled gracefully. After the upgrade to v5.2.1, this change and the connector would through an error
syntax error at or near ")"Fixes #483
Checklist
npm testpasses on your machine