Skip to content

fix: return correct model instance in createAll #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: return correct model instance in createAll #2027

merged 1 commit into from
Jan 24, 2023

Conversation

samarpanB
Copy link
Contributor

@samarpanB samarpanB commented Jan 22, 2023 •
edited
Loading

Signed-off-by: Samarpan Bhattacharya [email protected]

The retuning model from createAll was not correct. It was not returning the serialized instance. Now rectified it and made it similar to create() function.

Fixes loopbackio/loopback-connector-postgresql#530

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@samarpanB samarpanB requested a review from dhmlau as a code owner January 22, 2023 16:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3980627026

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 84.712%
Totals Coverage Status
Change from base Build 3945143922: 0.05%
Covered Lines: 7259
Relevant Lines: 8263
💛 - Coveralls

@samarpanB samarpanB mentioned this pull request Jan 22, 2023
Closed
@samarpanB samarpanB merged commit 316ebce into master Jan 24, 2023
@samarpanB samarpanB deleted the gh-530 branch January 24, 2023 16:18
@samarpanB samarpanB mentioned this pull request Jan 24, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achrinza achrinza achrinza approved these changes

@dhmlau dhmlau dhmlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Postgresql column as jsonb returning data as string using createAll() method
4 participants
@samarpanB @coveralls @achrinza @dhmlau