-
Notifications
You must be signed in to change notification settings - Fork 399
MSC2526: Add ability to delete key backups #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mscbot fcp merge |
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people: Concerns:
Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
# MSC2526: Add ability to delete key backups | ||
|
||
[MSC1219](https://github.com/matrix-org/matrix-doc/issues/1219) defined a | ||
mechanism for key backups. However, it inadvertently omitted the endpoint to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually thought this was deliberate so that there was always a way to rescue your keys (even if it involved your HS admin editing the database) and that we decided actually people should probably have the power to delete their own data from the server at the price of a potential footgun. Either way I think this is the right decision, just unsure about the history.
🔔 This is now entering its final comment period, as per the review above. 🔔 |
@richvdh the bot doesn't understand review comments. per #2526 (comment) : @mscbot concern please doc error cases |
The final comment period, with a disposition to merge, as per the review above, is now complete. |
Presuming the spec PR for this is #2387 |
Merged! 🎉 |
Rendered
Hopefully this is uncontroversial. I'd like to get this approved soon, since I'm preparing a spec PR for key backups (#2387), and would prefer to merge it all in one go, rather than making a separate PR to add this later.