Skip to content

MSC2526: Add ability to delete key backups #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2020

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented May 5, 2020

Rendered

Hopefully this is uncontroversial. I'd like to get this approved soon, since I'm preparing a spec PR for key backups (#2387), and would prefer to merge it all in one go, rather than making a separate PR to add this later.

@uhoreg uhoreg changed the title MSCxxxx: add ability to delete key backups MSC2526: Add ability to delete key backups May 5, 2020
@uhoreg uhoreg added the proposal A matrix spec change proposal label May 5, 2020
@uhoreg
Copy link
Member Author

uhoreg commented May 5, 2020

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented May 5, 2020

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • please doc error cases

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 5, 2020
# MSC2526: Add ability to delete key backups

[MSC1219](https://github.com/matrix-org/matrix-doc/issues/1219) defined a
mechanism for key backups. However, it inadvertently omitted the endpoint to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually thought this was deliberate so that there was always a way to rescue your keys (even if it involved your HS admin editing the database) and that we decided actually people should probably have the power to delete their own data from the server at the price of a potential footgun. Either way I think this is the right decision, just unsure about the history.

@mscbot
Copy link
Collaborator

mscbot commented May 12, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 12, 2020
@turt2live
Copy link
Member

@richvdh the bot doesn't understand review comments.

per #2526 (comment) :

@mscbot concern please doc error cases

@turt2live
Copy link
Member

A commit has been made, so leaving it to @richvdh to raise another concern if it's a problem:

@mscbot resolve please doc error cases

@mscbot
Copy link
Collaborator

mscbot commented May 17, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 17, 2020
@turt2live turt2live merged commit f9af712 into matrix-org:master May 18, 2020
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels May 18, 2020
@turt2live
Copy link
Member

Presuming the spec PR for this is #2387

@uhoreg uhoreg added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 2, 2020
@uhoreg
Copy link
Member Author

uhoreg commented Jun 2, 2020

Merged! 🎉

@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants