Skip to content

MSC2596: Proposal to always allow rescinding invites #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: old_master
Choose a base branch
from

Conversation

tulir
Copy link
Member

@tulir tulir commented Jun 1, 2020

@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposal-in-review labels Jun 1, 2020
tulir added 2 commits June 1, 2020 23:27
Signed-off-by: Tulir Asokan <[email protected]>
@turt2live turt2live self-requested a review June 2, 2020 15:47
## Proposal
The proposed fix is a modification to the authorization rules to always allow
rescinding invites that you sent. The modifications are applied on top of room
version 6. In section "5. If type is `m.room.member`" -> "d. If `membership`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit easier to reference this as "the m.room.member rules" as it's technically step 4 after applying all the diffs from the various room versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I fully understand my 4 year old comment here, but a link to the spec itself would be appreciated.

needed. Step `iii` is modified to add `invite` to the list of prohibited
previous membership states:

> iii. If *target user*'s current membership state is `invite`, `join` or `ban`, reject.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this would fix one bug, it introduces another: not being able to accept invites from dead homeservers. Currently if you have an invite from a dead server it is possible to convince another user to invite you instead, which doesn't involve room moderators (typically) getting involved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSC4125 should hopefully for the most part mitigate this issue.

@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
Comment on lines +35 to +36
The vendor-prefixed room version `net.maunium.msc2596` can be used until the
proposal is assigned to a future official room version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presuming net.maunium.msc2596 is based upon room version 11, given this does not appear to be implemented currently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be the case (second sentence of "proposal" section):

The modifications are applied on top of room version 6.

@turt2live turt2live added requires-room-version An idea which will require a bump in room version room-spec Something to do with the room version specifications unassigned-room-version Remove this label when things get versioned. labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal requires-room-version An idea which will require a bump in room version room-spec Something to do with the room version specifications unassigned-room-version Remove this label when things get versioned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants