-
Notifications
You must be signed in to change notification settings - Fork 399
MSC2596: Proposal to always allow rescinding invites #2596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: old_master
Are you sure you want to change the base?
Conversation
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
Signed-off-by: Tulir Asokan <[email protected]>
## Proposal | ||
The proposed fix is a modification to the authorization rules to always allow | ||
rescinding invites that you sent. The modifications are applied on top of room | ||
version 6. In section "5. If type is `m.room.member`" -> "d. If `membership` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit easier to reference this as "the m.room.member
rules" as it's technically step 4 after applying all the diffs from the various room versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I fully understand my 4 year old comment here, but a link to the spec itself would be appreciated.
needed. Step `iii` is modified to add `invite` to the list of prohibited | ||
previous membership states: | ||
|
||
> iii. If *target user*'s current membership state is `invite`, `join` or `ban`, reject. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this would fix one bug, it introduces another: not being able to accept invites from dead homeservers. Currently if you have an invite from a dead server it is possible to convince another user to invite you instead, which doesn't involve room moderators (typically) getting involved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSC4125 should hopefully for the most part mitigate this issue.
The vendor-prefixed room version `net.maunium.msc2596` can be used until the | ||
proposal is assigned to a future official room version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presuming net.maunium.msc2596
is based upon room version 11, given this does not appear to be implemented currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to be the case (second sentence of "proposal" section):
The modifications are applied on top of room version 6.
Rendered
This would solve matrix-org/matrix-spec#172