Add syntax for qualified types #8
Conversation
6045a23 to
1c74ac1
Compare
| @@ -158,6 +160,10 @@ object Feature: | |||
| if ctx.run != null then ctx.run.nn.ccEnabledSomewhere | |||
| else enabledBySetting(captureChecking) | |||
|
|
|||
| /** Is qualifiedTypes enabled for this compilation unit? */ | |||
| def qualifiedTypesEnabled(using Context) = | |||
| enabledBySetting(qualifiedTypes) | |||
There was a problem hiding this comment.
This only checks if the feature is enabled by a setting. I see that you also added object qualifiedTypes in language.scala. We probably want to do enabled(qualifiedTypes) then.
There was a problem hiding this comment.
We cannot isolate Qualified Types to one scope, as they might escape in a number of ways
Therefore it only makes sense to be enabled or disabled overall
This is similar to what is done for capture types
There was a problem hiding this comment.
Ah right, now I remember, thanks @Sporarum. So we should probably do like for capture checking, and I should remove object qualifiedTypes.
There was a problem hiding this comment.
Oh, and now I remember why I needed object qualifiedTypes: it is used to know that the qualifiedTypes feature is experimental. If I remove it, I get the following error:
-- Error: tests/printing/qualifiers.scala:26:9 ---------------------------------
26 | val x: Int with x > 0 = 1
| ^
| class qualified is marked @experimental
|
| Experimental definition may only be used under experimental mode:
| 1. in a definition marked as @experimental, or
| 2. an experimental feature is imported at the package level, or
| 3. compiling with the -experimental compiler flag.
There was a problem hiding this comment.
The logic that does that is in Feature.experimentalAutoEnableFeatures I believe.
There was a problem hiding this comment.
Ok, that makes sense. Thanks for explaining.
| @@ -156,6 +156,9 @@ object untpd extends Trees.Instance[Untyped] with UntypedTreeInfo { | |||
| */ | |||
| case class CapturesAndResult(refs: List[Tree], parent: Tree)(implicit @constructorOnly src: SourceFile) extends TypTree | |||
|
|
|||
| /** { x: T with p } (only relevant under qualifiedTypes) */ | |||
There was a problem hiding this comment.
Could you make the example use the case class parameters? and possibly explain what a missing paramName means?
| @@ -65,6 +66,7 @@ object Feature: | |||
| (clauseInterleaving, "Enable clause interleaving"), | |||
| (pureFunctions, "Enable pure functions for capture checking"), | |||
| (captureChecking, "Enable experimental capture checking"), | |||
| (qualifiedTypes, "Enable experimental qualified types"), | |||
There was a problem hiding this comment.
We probably don't need to say "experimental" here, it might change at some point 😅
There was a problem hiding this comment.
This seems to be the standard for experimental features, I see no reason to deviate
(And when the time comes, we can change description)
There was a problem hiding this comment.
Yeah, as for many things, we just copied what was done for capture checking, one line above in this case. I also think keeping experimental for now is probably okay.
There was a problem hiding this comment.
Ok, sure. I just looked at the other experimental features and only two of them explicitly say that they are experimental, so it seemed to deviate from the standard. Still, it's not a strong opinion and doesn't really matter.
| @@ -2034,6 +2071,8 @@ object Parsers { | |||
| atSpan(in.offset) { | |||
| makeTupleOrParens(inParensWithCommas(argTypes(namedOK = false, wildOK = true, tupleOK = true))) | |||
| } | |||
| else if in.token == LBRACE && followingIsQualifiedType() then | |||
There was a problem hiding this comment.
Can we merge parsing qualified types and refinements and get rid of the lookahead?
There was a problem hiding this comment.
I think I tried, but couldn't manage to, but that doesn't mean it's impossible
There was a problem hiding this comment.
Good point.
I just made a test trying with a single lookahead to see if the next character is an IDENT and it seems to work. Maybe we needed an additional lookahead (':') only for the lambda syntax? I'll further test my change.
There was a problem hiding this comment.
It seems to work: 23114ba.
cb7be48 to
23114ba
Compare
Co-Authored-By: Quentin Bernet <[email protected]>
This is a port of @Sporarum's work with the following changes:
QualifiedTypeTreethat is desugared into an annotation duringTyperinstead of creating the annotation during parsing already. This is more in-line with how similar features are implemented and is preferred by IDEs developers according to Martin.