Skip to content

Conversation

yxrkt
Copy link

@yxrkt yxrkt commented Jun 6, 2020

Certain responses state that they can return arrays (Document Color Request, for example).

Certain responses state that they can return arrays (Document Color Request, for example).
@dbaeumer
Copy link
Member

dbaeumer commented Nov 5, 2021

Correct. Merged by hand into 3.17.

@dbaeumer dbaeumer closed this Nov 5, 2021
@dbaeumer dbaeumer added this to the 3.17 milestone Nov 5, 2021
@darichey
Copy link

@dbaeumer Was this merged correctly? The current spec doesn't reflect the change.

@KamasamaK
Copy link
Contributor

The commit history does not show that this was ever corrected for 3.17.

@dbaeumer
Copy link
Member

Actually my conclusion was that object in TS includes array and therefore didn't add it. But this might not be obvious for everybody. But adding it might include confusion as well. May be we should add a comment somewhere.

@darichey
Copy link

That's fair, but array | object appears in other places in the spec (RequestMessage.params, ResponseError.data, NotificationMessage.params).

Personally, I think that they should be consistent and that explicitly including array is more clear.

@dbaeumer
Copy link
Member

Good point.

@dbaeumer
Copy link
Member

Added array

facebook-github-bot pushed a commit to facebook/flow that referenced this pull request Feb 15, 2023
Summary:
See
* https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#responseMessage
* microsoft/language-server-protocol#1012

Changelog: [internal]

Reviewed By: mroch

Differential Revision: D43279313

fbshipit-source-id: c397f4f0ba7ac8a297f6334aecc7ed166ea8e40d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants