Skip to content

Remove return from example addAction #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2021
Merged

Remove return from example addAction #2772

merged 1 commit into from
Nov 16, 2021

Conversation

MasterOdin
Copy link
Contributor

Documentation for editor.AddAction gives a return type of void | Promise<void>. Having the example return null is confusing given it doesn't really matter what it returns.

@alexdima
Copy link
Member

Thank you!

@alexdima alexdima added this to the November 2021 milestone Nov 16, 2021
@alexdima alexdima merged commit 6535feb into microsoft:main Nov 16, 2021
@MasterOdin MasterOdin deleted the patch-1 branch January 6, 2022 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
November 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterOdin @alexdima