Allow extensions to disable built-in markdown preview button #136273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a flag for the "Open Preview to the Side" button displayed for markdown files. This makes it possible for extensions to hide this button when desired by setting the flag to true. For example, extensions can now use the following line to disable the preview button:
```js
vscode.commands.executeCommand("setContext", "hasCustomMarkdownView", true);
```
12 tasks
mjbvz
reviewed
Nov 3, 2021
| @@ -99,7 +99,7 @@ | |||
| "editor/title": [ | |||
| { | |||
| "command": "markdown.showPreviewToSide", | |||
| "when": "editorLangId == markdown && !notebookEditorFocused", | |||
| "when": "editorLangId == markdown && !notebookEditorFocused && !hasCustomMarkdownView", | |||
There was a problem hiding this comment.
[nit] Can we call this hasCustomMarkdownPreview instead? That way it's super clear this is about the md preview
Otherwise looks good to me
|
To help us track this work, can you also please open an issue that briefly describes the problem this PR fixes |
Thanks for the feedback @mjbvz, I updated the keyword used, and created and linked an issue. Please let me know if anything else needs to be done on my end. |
|
Thanks! Will be in the next VS Code 1.63 insiders |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag for the "Open Preview to the Side" button displayed for markdown files. This makes it possible for extensions to hide this button when desired by setting the flag to true. For example, extensions can now use the following line to disable the preview button:
Issue: #136388
Regularly:
With the default markdown preview button disabled by an extension:
