Skip to content

Fixes glob patterns **/p* incorrectly match on /foo/ap #144473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2022

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Mar 5, 2022

This PR fixes #144458

@bpasero bpasero added this to the March 2022 milestone Mar 6, 2022
@bpasero
Copy link
Member

bpasero commented Mar 6, 2022

@jeanp413 thanks a ton, looks like a very elegant solution. And I think it uncovered an issue with one of our tests that wrongly asserted a glob pattern to match a file that it shouldn't match. Specifically:

**/[._]*.s[a-w][a-z] should not match /._._sby because in the pattern there is an extra . after the [._] but before the s and thus the pattern cannot match. Fyi @JacksonKearl I think you had added these tests originally.

@bpasero bpasero merged commit e80a0ca into microsoft:main Mar 6, 2022
@jeanp413 jeanp413 deleted the fix-144458 branch March 6, 2022 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glob patterns **/p* incorrectly match on /foo/ap
2 participants