Skip to content

Add duration to the terminal command SI tooltip #199357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2024
Merged

Add duration to the terminal command SI tooltip #199357

merged 3 commits into from
Jan 31, 2024

Conversation

hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented Nov 28, 2023

fix #199170

@hsfzxjy hsfzxjy force-pushed the terminal-si-help-duration-199170 branch from 89d2f4f to 9a61ab7 Compare November 28, 2023 14:36
Tyriar
Tyriar reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast! Looks great after a quick check. Since we just started testing I'll move this to get reviewed/merged next month.

@Tyriar Tyriar added this to the December 2023 milestone Nov 28, 2023
@aiday-mar aiday-mar modified the milestones: December / January 2024, February 2024 Jan 24, 2024
@Tyriar Tyriar enabled auto-merge January 31, 2024 20:14
@Tyriar Tyriar merged commit 8d961d7 into microsoft:main Jan 31, 2024
@hsfzxjy hsfzxjy deleted the terminal-si-help-duration-199170 branch February 1, 2024 01:40
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
February 2024
Development

Successfully merging this pull request may close these issues.

Add duration to the terminal command SI tooltip
4 participants
@hsfzxjy @Tyriar @aeschli @aiday-mar