Skip to content

Introduce Collapse All Action to Loaded Scripts #203560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Conversation

jnnklhmnn
Copy link
Contributor

Fixes: #64314

@jnnklhmnn
Copy link
Contributor Author

@microsoft-github-policy-service agree

@roblourens roblourens added this to the February 2024 milestone Jan 26, 2024
roblourens
roblourens previously approved these changes Jan 28, 2024
title: nls.localize('collapse', "Collapse All"),
f1: false,
icon: Codicon.collapseAll,
precondition: CONTEXT_DEBUG_STATE.isEqualTo(getStateLabel(State.Stopped)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this precondition? I can use Loaded Scripts even when not paused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roblourens Good call! This was indeed not needed, removed the condition in this commit: 30262b9

@roblourens roblourens enabled auto-merge (squash) January 29, 2024 14:13
@roblourens roblourens merged commit 7a30d30 into microsoft:main Jan 29, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loaded scripts should have a collapse all action
3 participants