feat: port autocomplete direct commands and browser-runtime-core to the new autocomplete MONGOSH-2205 MONGOSH-2035 MONGOSH-2206 #2464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Jun 3, 2025
lerouxb
commented
Jun 3, 2025
lerouxb
commented
Jun 3, 2025
| getDatabaseCompletions: (dbName: string) => string[] | Promise<string[]>; | ||
| } | ||
|
|
||
| export type NewShellCommandAutocompleteParameters = Pick< |
There was a problem hiding this comment.
Don't know how obvious it is from the diff, but this is just new types everywhere ShellCommand* was with that now the legacy type. We'll have to just clean this up when we remove the old autocompleter.
Again: open to suggestions for how to rather do this.
lerouxb
commented
Jun 3, 2025
| async function showCompleter( | ||
| params: ShellCommandAutocompleteParameters, | ||
| // eslint-disable-next-line no-control-regex | ||
| const CONTROL_CHAR_REGEXP = /[\x00-\x1F\x7F-\x9F]/g; |
There was a problem hiding this comment.
This is now the third copy of this regex..
418b8a0 to
a0b44cb
Compare
addaleax
reviewed
Jun 5, 2025
|
|
||
| return dbNames.filter( | ||
| (name) => | ||
| name.toLowerCase().startsWith(prefix) && !CONTROL_CHAR_REGEXP.test(name) |
There was a problem hiding this comment.
For use we'd probably want to be a bit stricter and only allow alphanumeric names, no?
There was a problem hiding this comment.
I just copied this from what we had, but I can change it.
addaleax
reviewed
Jun 5, 2025
addaleax
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially reuses (as in makes a copy of) the existing direct shell command autocompleter and then ports it to use the new AutocompleteContext vs the old AutocompleteParams. Unfortunately it meant more duplicate types and props between the old and new than I'd really like, but this way at least means we can have the feature flag and keep the old way around for now. But I'm open to suggestion.
I also fixed up the code that initialises the autocompleter and uses it, moving to packages/autocomplete in the process. This way the common code can be reused between the cli and browser repls. It lives in packages/autocomplete. The idea is we'd remove the old autocomplete code from there and keep this new wrapper.
Then to validate that the above design works I ported usage of autocomplete in browser-runtime-core to do the same thing we do in cli-repl. I ported its tests too, so you can do:
I also narrowed some types along the way just to make porting tests a bit easier without requiring all of ShellInstanceState, for example.