MONGOID-5758: Add Mongoid.reconnect_clients and improve forking webserver documentation #5808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Mongoid.reconnect_clients (analogous to Mongoid.disconnect_clients). The reason for adding this is to simply web server hooks (see added docs.) - Corrects the @return in the docs for disconnect_clients. Also added specs for the existing behavior. - Updates documentation related to web server forking.
|
FYI I've verified the documentation and changes here in my production Puma app. |
jamis
requested changes
Apr 8, 2024
jamis
approved these changes
Apr 22, 2024
brennana
pushed a commit
to hundio/mongoid
that referenced
this pull request
Jun 7, 2024
…rver documentation (mongodb#5808) * This PR does the following: - Add Mongoid.reconnect_clients (analogous to Mongoid.disconnect_clients). The reason for adding this is to simply web server hooks (see added docs.) - Corrects the @return in the docs for disconnect_clients. Also added specs for the existing behavior. - Updates documentation related to web server forking. * Fix method name * More terse syntax * Preserve old return type * Update configuration.txt * Update configuration.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Mongoid.reconnect_clientsmethod analogous toMongoid.disconnect_clients. The reason for adding this is to simplify web server hooks (see added docs.)@returnin the docs fordisconnect_clients. Also added specs which cover the existing behavior.This will hopefully help others avoid issues we saw in our production.
See also: mongodb/mongo-ruby-driver#2856