Return early if a directory isn't managed by git #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes things much faster for large non-git trees that happen to have setuptools_git among their indirect requirements. For example, this takes Launchpad's "python setup.py egg_info" from 16 seconds to 2 seconds for me.
|
Thanks, @cjwatson! |
|
Released in https://pypi.python.org/pypi/setuptools-git/1.2. Thanks again, @cjwatson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes things much faster for large non-git trees that happen to
have setuptools_git among their indirect requirements. For example,
this takes Launchpad's "python setup.py egg_info" from 16 seconds to 2
seconds for me.
#6 would probably help as well, not to mention optimising the realpath handling so that it doesn't unnecessarily re-stat every path element for every file in your tree, which is a candidate for http://accidentallyquadratic.tumblr.com/ . But this is easy and non-intrusive.