[FIXED] Ensure $SYS.REQ.USER.INFO is only answered by correct server
#7089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/events.go
Outdated
| @@ -1495,6 +1495,12 @@ func (s *Server) userInfoReq(sub *subscription, c *client, _ *Account, subject, | |||
| return | |||
| } | |||
|
|
|||
| // Only the server that the client is connected to should answer, otherwise | |||
| // we may not know about their connection JWT etc. | |||
| if ci.Server != s.Name() { | |||
There was a problem hiding this comment.
We have ways for subs to not propagate interest to other servers, the sub for this one should have been that I believe. Will check the original sub code for that endpoint.
There was a problem hiding this comment.
Switched to this approach instead, seems to solve the problem more elegantly.
All servers in the cluster were unexpectedly attempting to respond, but only the server that the client is connected to would know about the auth credentials. It was effectively a race condition which response would make it back to the client first. Fixes #7088. Signed-off-by: Neil Twigg <[email protected]>
47b01c2 to
84b7c8f
Compare
$SYS.REQ.USER.INFO is only answered by correct server$SYS.REQ.USER.INFO is only answered by correct server
neilalexander
added a commit
that referenced
this pull request
Jul 25, 2025
Includes the following: - #7031 - #7033 - #7034 - #7035 - #7036 - #7040 - #7043 - #7045 - #7047 - #7046 - #7050 - #7051 - #7052 - #7053 - #7061 - #7063 - #7064 - #7065 - #7066 - #7070 - #7072 - #7080 - #7026 - #6728 - #7074 - #7089 - #7095 - #7087 - #7094 - #7096 - #7099 Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All servers in the cluster were unexpectedly attempting to respond, but only the server that the client is connected to would know about the auth credentials. It was effectively a race condition which response would make it back to the client first.
Fixes #7088.
Signed-off-by: Neil Twigg [email protected]