(2.12) Add Prioritized to the Consumer Priority Modes #7113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a8298a to
30229a0
Compare
MauriceVanVeen
approved these changes
Aug 7, 2025
server/consumer.go
Outdated
| wr.n-- | ||
|
|
||
| if wr.n > 0 && wq.n > 1 { | ||
| if wq.head.next == nil { |
There was a problem hiding this comment.
Suggested change
| if wq.head.next == nil { | |
| if wr.next == nil { |
server/consumer.go
Outdated
Comment on lines
3569
to
3599
| // Find insertion point - insert before first element with higher priority | ||
| var prev *waitingRequest | ||
| current := wq.head | ||
|
|
||
| for current != nil { | ||
| currentPriority := math.MaxInt32 | ||
| if current.priorityGroup != nil { | ||
| currentPriority = current.priorityGroup.Priority | ||
| } | ||
| // Insert before the first element with higher priority (stable sort) | ||
| if currentPriority > priority { | ||
| break | ||
| } | ||
| prev = current | ||
| current = current.next | ||
| } | ||
|
|
||
| // Insert at found position | ||
| if prev == nil { | ||
| // Insert at head (lowest priority so far) | ||
| wr.next = wq.head | ||
| wq.head = wr | ||
| } else { | ||
| // Insert after prev | ||
| wr.next = prev.next | ||
| prev.next = wr | ||
| if wr.next == nil { | ||
| // We're the new tail | ||
| wq.tail = wr | ||
| } | ||
| } |
There was a problem hiding this comment.
This same logic is also used in popAndRequeue. Could perhaps extract this logic and reuse it in both insertSorted and popAndRequeue.
This was referenced Aug 7, 2025
ripienaar
reviewed
Aug 7, 2025
This adds Prioritized mode to the PriorityGroups, which allows for a low-latency switch between clients depending on priority set. Refer ADR-42 for more details. Signed-off-by: Tomasz Pietrek <[email protected]>
98a4c29 to
dbeca22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Prioritized mode to the PriorityGroups, which allows for a low-latency switch between clients depending on priority set.
Refer ADR-42 for more details.
Signed-off-by: Tomasz Pietrek [email protected]