[FIXED] Detect removed blocks with stale index.db #7123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <[email protected]>
neilalexander
added a commit
that referenced
this pull request
Jul 31, 2025
Includes the following: * #7117 * #7123 Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filestore could contain 3 blocks, had a successful write to the last message block, and wrote a valid
index.dbcontaining those 3 blocks. If a block was deleted (but was not the last) and the server had an ungraceful shutdown, the removed block was not recognized. This would result in theindex.dbbeing regarded as valid and loading messages in that block to returnloadBlock error: message block data missingerrors.This PR fixes that by recognizing certain files don't exist on disk anymore, adds those to the lost data, and rebuilds the index.
Signed-off-by: Maurice van Veen [email protected]